Page MenuHomePhabricator

Assume utf8mb4 support
ClosedPublic

Authored by epriestley on Nov 6 2014, 9:09 PM.
Tags
None
Referenced Files
F18618994: D10798.diff
Sep 15 2025, 1:29 AM
F18297177: D10798.id25951.diff
Aug 23 2025, 4:28 PM
F18297175: D10798.id.diff
Aug 23 2025, 4:27 PM
F18093052: D10798.id25951.diff
Aug 7 2025, 3:04 PM
F18088818: D10798.id25917.diff
Aug 6 2025, 9:41 AM
F18088661: D10798.id.diff
Aug 6 2025, 8:50 AM
F18082872: D10798.diff
Aug 5 2025, 7:42 AM
F17950122: D10798.id25917.diff
Aug 1 2025, 12:08 AM
Subscribers

Details

Summary

Ref T1191. This stops throwing an exception for non-BMP data when constructing queries.

  • For installs which have already adjusted, this allows emoji and other 4-byte characters to work.
  • For installs which have not adjusted yet but do have STRICT_ALL_TABLES set, MySQL will raise an error intead ("Incorrect string value...").
  • For installs which have not adjusted and also do not use STRICT_ALL_TABLES, this will silently truncate data. This is potentially a security risk. However, these installs are warned about the risk of leaving STRICT_ALL_TABLES disabled, there's no known way to exploit this issue, and they'll be auto-adjusted soon.
Test Plan

Ran locally and on secure.phabricator.com with this patch for a long time.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable