Page MenuHomePhabricator

Assume utf8mb4 support
ClosedPublic

Authored by epriestley on Nov 6 2014, 9:09 PM.

Details

Summary

Ref T1191. This stops throwing an exception for non-BMP data when constructing queries.

  • For installs which have already adjusted, this allows emoji and other 4-byte characters to work.
  • For installs which have not adjusted yet but do have STRICT_ALL_TABLES set, MySQL will raise an error intead ("Incorrect string value...").
  • For installs which have not adjusted and also do not use STRICT_ALL_TABLES, this will silently truncate data. This is potentially a security risk. However, these installs are warned about the risk of leaving STRICT_ALL_TABLES disabled, there's no known way to exploit this issue, and they'll be auto-adjusted soon.
Test Plan

Ran locally and on secure.phabricator.com with this patch for a long time.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable