These changes allow detection of files, that come from folder's "svn:externals" property. Before only folders were properly detected.
Fixes T6447
Details
Details
- Reviewers
- None
- Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6447: SVN file externals aren't properly detected
- create 2 svn repositories (internally these can be 2 folders on same SVN server of course)
- configure 2nd folder to include one folder and one file (try binary file, like "favicon.ico") via "svn:externals" property
- checkout 2nd folder
- try running arc diff
Before this would result in UTF-8 encoding error on binary file that came from "svn:externals". Now file will be properly skipped.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- T6447
- Lint
Lint Warnings Severity Location Code Message Warning src/repository/api/ArcanistSubversionAPI.php:97 TXT3 Line Too Long - Unit
Test Failures - Build Status
Buildable 2930 Build 2934: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 0 ms | testHgStateParsing | |
| 0 ms | testGitStateParsing | |
| 0 ms | testSVNFileEscapes | |
| 0 ms | testSvnStateParsing |
Event Timeline
Comment Actions
I've updated Mercurial installation to 3.1.2 and tests passed. I'm not sure how can I make arc to update unit test results for existing differential revision without changing any files in it.