Added support for parsing PhpStorm produced patches
Needs ReviewPublic
Actions

Authored by aik099 on Nov 1 2014, 11:45 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4698: Support for SVN patches, created by PhpStorm

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

With these changes it's now possible to do 2 things with patches, created by PhpStorm:

validate that PhpStorm-specific comment, that follows after each changed filename is correct (all lines present)
don't consider such patches as malformed and allow them to be uploaded

Fixes T4698

Test Plan

create patch in PhpStorm (or take "phpstorm-multiple-files.svndiff" from this revision)
try creating new/updating existing differential revision
see that no error happens and patch is recognized

Repository

rARC Arcanist

Branch

T4698

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/parser/__tests__/diff/phpstorm-multiple-files.svndiff:6	TXT2	Tab Literal
Auto-Fix	src/parser/__tests__/diff/phpstorm-multiple-files.svndiff:10	TXT6	Trailing Whitespace
Auto-Fix	src/parser/__tests__/diff/phpstorm-multiple-files.svndiff:38	TXT6	Trailing Whitespace

Unit

Tests Passed

Build Status

Buildable 2926
Build 2930: [Placeholder Plan] Wait for 30 Seconds

aik099 retitled this revision from to Added support for parsing PhpStorm produced patches.

aik099 updated this object.

aik099 edited the test plan for this revision. (Show Details)

aik099 added a reviewer: epriestley.

src/parser/ArcanistDiffParser.php
687	This line was uncovered before my changes. Another line in added `processIDEAComment` method isn't covered due same reason: exception assertion isn't used. To improve situation I recommend (in another Differential revision of course) to: add `$expected_exception_message` argument to `ArcanistPhutilTestCase::assertException` method assert different exceptions (depending on parsed diff) in `ArcanistDiffParserTestCase::parseDiff` method