Page MenuHomePhabricator
Differential D10672

Smooth out Phortune purchase completion flow
ClosedPublic
Actions

Authored by epriestley on Oct 9 2014, 6:24 PM.
Tags
None
Referenced Files
F15524478: D10672.id25631.diff
Mon, Apr 21, 8:15 AM
F15519475: D10672.id25628.diff
Sat, Apr 19, 11:32 PM
F15518078: D10672.id.diff
Sat, Apr 19, 10:42 AM
F15515399: D10672.diff
Fri, Apr 18, 10:08 AM
F15459962: D10672.id25631.diff
Mon, Mar 31, 6:38 PM
F15459608: D10672.id25631.diff
Mon, Mar 31, 2:31 PM
F15454879: D10672.diff
Sat, Mar 29, 8:59 PM
F15449458: D10672.id25631.diff
Fri, Mar 28, 10:25 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2787: Build Phortune into a real accounts/billing application
Commits
Restricted Diffusion Commit
rPf53861aa9da2: Smooth out Phortune purchase completion flow
Summary

Ref T2787. Currently, we dump the user back into the application. Instead, give them a confirmation screen and then let them continue.

Also fix a couple of unit tests I adjusted the underlying behavior of somewhat-recently in libphutil.

Test Plan

Screen_Shot_2014-10-09_at_11.16.35_AM.png (1×1 px, 136 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25628.Oct 9 2014, 6:24 PM
epriestley retitled this revision from to Smooth out Phortune purchase completion flow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2787: Build Phortune into a real accounts/billing application.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 9 2014, 6:24 PM
Harbormaster completed remote builds in B2792: Diff 25628.Oct 9 2014, 6:25 PM
btrahan accepted this revision.Oct 9 2014, 11:17 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 9 2014, 11:17 PM
Closed by commit rPf53861aa9da2: Smooth out Phortune purchase completion flow (authored by epriestley, committed by epriestley).Oct 9 2014, 11:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
fund/
phortune/
4 lines
phortune/
cart/
4 lines
controller/
2 lines
27 lines
provider/
2 lines
2 lines
storage/
4 lines
view/
__tests__/
32 lines
phui/
2 lines

Diff 25631

View Options

src/applications/fund/phortune/FundBackerCart.php

Loading...
View Options

src/applications/phortune/cart/PhortuneCartImplementation.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartCheckoutController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartViewController.php

Loading...
View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

Loading...
View Options

src/applications/phortune/provider/PhortuneWePayPaymentProvider.php

Loading...
View Options

src/applications/phortune/storage/PhortuneCart.php

Loading...
View Options

src/view/__tests__/PhabricatorUnitsTestCase.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
Phabricator · Built by Phacility