Page MenuHomePhabricator

Add a HOLD state to Phortune and handle unusual states better
ClosedPublic

Authored by epriestley on Oct 8 2014, 11:48 PM.
Tags
None
Referenced Files
F15435170: D10667.id.diff
Tue, Mar 25, 7:13 AM
F15418556: D10667.id25620.diff
Fri, Mar 21, 12:02 AM
F15417048: D10667.id.diff
Thu, Mar 20, 3:00 PM
F15416279: D10667.id25624.diff
Thu, Mar 20, 10:15 AM
F15408283: D10667.diff
Tue, Mar 18, 10:11 PM
F15393227: D10667.id25624.diff
Mar 15 2025, 8:31 PM
F15388505: D10667.id25620.diff
Mar 15 2025, 3:56 AM
Unknown Object (File)
Feb 7 2025, 11:42 PM
Subscribers

Details

Summary

Ref T2787. When Paypal comes back to us with funds on hold, dead-end the transaction but handle it properly.

Generally, smooth out the user interaction on weird states.

Implement refudnds/cancels for Paypal.

Test Plan

Screen_Shot_2014-10-08_at_4.47.27_PM.png (1×1 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a HOLD state to Phortune and handle unusual states better.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

An idea for later mayhaps inline.

src/applications/phortune/controller/PhortuneCartViewController.php
47

Ideally 'contact the merchant' is a link

This revision is now accepted and ready to land.Oct 9 2014, 2:16 AM

Yeah, I'm not sure where I want to go with that. I figure we're going to be the only ones using this for a while and it's well documented how to get in touch with us, but I could imagine some more formal system down the road.

This revision was automatically updated to reflect the committed changes.