Page MenuHomePhabricator
Differential D10666

Handle Phortune charge failures cleanly
ClosedPublic
Actions

Authored by epriestley on Oct 8 2014, 10:33 PM.
Tags
None
Referenced Files
F14063515: D10666.diff
Mon, Nov 18, 6:50 PM
F14003860: D10666.id25621.diff
Sat, Oct 26, 11:38 AM
F14000963: D10666.diff
Fri, Oct 25, 2:48 AM
Unknown Object (File)
Sep 30 2024, 9:29 AM
Unknown Object (File)
Sep 27 2024, 9:10 AM
Unknown Object (File)
Sep 27 2024, 9:06 AM
Unknown Object (File)
Sep 27 2024, 9:05 AM
Unknown Object (File)
Sep 27 2024, 9:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2787: Build Phortune into a real accounts/billing application
Commits
Restricted Diffusion Commit
rPad991b019709: Handle Phortune charge failures cleanly
Summary

Ref T2787. Currently, we kill a cart and dead-end the workflow on a charge failure.

Instead, fail the charge and reset the cart so the user can try using a valid payment instrument like a normal checkout workflow would.

Some shakiness/smoothing on WePay for the moment; PayPal is still made up since we don't have a "Hold" state yet.

Test Plan

Screen_Shot_2014-10-08_at_3.28.16_PM.png (1×1 px, 186 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25613.Oct 8 2014, 10:33 PM
epriestley retitled this revision from to Handle Phortune charge failures cleanly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2787: Build Phortune into a real accounts/billing application.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 8 2014, 10:33 PM
Harbormaster completed remote builds in B2783: Diff 25613.Oct 8 2014, 10:33 PM
btrahan accepted this revision.Oct 8 2014, 10:49 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 8 2014, 10:49 PM
Closed by commit rPad991b019709: Handle Phortune charge failures cleanly (authored by epriestley, committed by epriestley).Oct 9 2014, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
2 lines
phortune/
controller/
15 lines
provider/
22 lines
63 lines
storage/
31 lines

Diff 25621

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartCheckoutController.php

Loading...
View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

Loading...
View Options

src/applications/phortune/provider/PhortuneWePayPaymentProvider.php

Loading...
View Options

src/applications/phortune/storage/PhortuneCart.php

Loading...
Phabricator · Built by Phacility