Differential D10640

Give Stripe complete payment workflow logic in Phortune
ClosedPublic
Actions

Authored by epriestley on Oct 6 2014, 7:10 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2787: Build Phortune into a real accounts/billing application

Commits

Restricted Diffusion Commit
rP83e1a1ddb206: Give Stripe complete payment workflow logic in Phortune

Summary

Ref T2787. This basically already works correctly since the hard logic is external to the provider on API providers. Tweak a couple of things.

Failures still just fail the cart completely, for now.

Test Plan

Completed a charge with Stripe.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25553.Oct 6 2014, 7:10 PM

epriestley retitled this revision from to Give Stripe complete payment workflow logic in Phortune.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2787: Build Phortune into a real accounts/billing application.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 6 2014, 7:10 PM

Harbormaster completed remote builds in B2752: Diff 25553.Oct 6 2014, 7:11 PM

btrahan accepted this revision.Oct 6 2014, 8:03 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 6 2014, 8:03 PM

Closed by commit rP83e1a1ddb206: Give Stripe complete payment workflow logic in Phortune (authored by epriestley, committed by epriestley).Oct 6 2014, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

provider/

PhortuneStripePaymentProvider.php

10 lines

PhortuneWePayPaymentProvider.php

7 lines

Diff 25564

View Options

src/applications/phortune/provider/PhortuneStripePaymentProvider.php