Page MenuHomePhabricator

Give WePay complete payment logic in Phortune
ClosedPublic

Authored by epriestley on Oct 6 2014, 7:02 PM.
Tags
None
Referenced Files
F13087219: D10639.diff
Thu, Apr 25, 12:54 AM
Unknown Object (File)
Sun, Apr 7, 11:06 PM
Unknown Object (File)
Sat, Apr 6, 9:52 PM
Unknown Object (File)
Mar 20 2024, 5:53 PM
Unknown Object (File)
Jan 28 2024, 10:41 AM
Unknown Object (File)
Jan 23 2024, 12:56 PM
Unknown Object (File)
Jan 21 2024, 3:44 AM
Unknown Object (File)
Dec 25 2023, 3:23 AM
Subscribers

Details

Summary

Ref T2787. This doesn't get all the edge cases quite correct, but is generally a safe, complete payment workflow:

  • Shares the actual charging state logic.
  • Makes it appropriately stateful with locking and transactions.
  • Gets the main flow correct.
  • Detects failure cases, just tends to blow up rather than help the user resolve them.
Test Plan
  • Charged with WePay.
  • Charged with Infinite Free Money.
  • Resumed an abandoned cart.
  • Hit all failure states where we just dead-end the cart. Not ideal, but (seemingly) complete/safe/correct.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give WePay complete payment logic in Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 8:02 PM
This revision was automatically updated to reflect the committed changes.