Differentiate between "no pygmetnize" and "nonworking pygmentize" during setup
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 4:25 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6210: Detect if pygmentize exists but fails to execute

Commits

Restricted Diffusion Commit
rP3c6781b177d4: Differentiate between "no pygmetnize" and "nonworking pygmentize" during setup

Summary

Fixes T6210. The current messaging may be confusing if pygmentize is available but broken.

Test Plan

Faked the binary names and hit the errors, which seemed helpful.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25508.Oct 2 2014, 4:25 PM

epriestley retitled this revision from to Differentiate between "no pygmetnize" and "nonworking pygmentize" during setup.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6210: Detect if pygmentize exists but fails to execute.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 4:25 PM

Harbormaster completed remote builds in B2724: Diff 25508.Oct 2 2014, 4:26 PM

btrahan accepted this revision.Oct 2 2014, 4:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2014, 4:40 PM

Closed by commit rP3c6781b177d4: Differentiate between "no pygmetnize" and "nonworking pygmentize" during setup (authored by epriestley, committed by epriestley).Oct 2 2014, 4:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorSetupCheckPygment.php

25 lines

Diff 25509

View Options

src/applications/config/check/PhabricatorSetupCheckPygment.php

Differentiate between "no pygmetnize" and "nonworking pygmentize" during setupClosedPublicActions