Page MenuHomePhabricator

Make execution order of Herald rules explicit
ClosedPublic

Authored by epriestley on Oct 2 2014, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:28 PM
Unknown Object (File)
Feb 17 2024, 2:13 AM
Unknown Object (File)
Feb 13 2024, 11:32 PM
Unknown Object (File)
Feb 8 2024, 4:31 AM
Unknown Object (File)
Feb 8 2024, 4:26 AM
Unknown Object (File)
Feb 6 2024, 4:13 PM
Unknown Object (File)
Feb 6 2024, 11:14 AM
Unknown Object (File)
Jan 25 2024, 11:34 AM
Subscribers

Details

Summary

Fixes T6211. This gives Herald rules an explicit execution order, which seems generally good. See some discussion on T6211 and inline.

Test Plan
  • Added unit test.
  • Dry ran rules and saw rules appear in the expected order in the transcript.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make execution order of Herald rules explicit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2014, 4:39 PM
This revision was automatically updated to reflect the committed changes.