Page MenuHomePhabricator

Remove UTF8 BMP unit test and replace it with a general UTF8 test
ClosedPublic

Authored by epriestley on Oct 2 2014, 3:31 PM.

Details

Summary

Ref T1191. After utf8mb4 conversion, these tests no longer pass because MySQL allows emoji and gclefs and such.

We could keep these tests running by keeping a ut8f_bin table around somewhere, but we have no other use cases for it and it does not seem worth the added complexity. All these BMP-only codepaths are on the way out.

Update the %s / %B test to make sure it's rejecting invalid byte sequences, which are still not permitted.

Test Plan

Tests now pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove UTF8 BMP unit test and replace it with a general UTF8 test.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2014, 4:38 PM
This revision was automatically updated to reflect the committed changes.