Remove UTF8 BMP unit test and replace it with a general UTF8 test
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 3:31 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rP410c2ecbfdf7: Remove UTF8 BMP unit test and replace it with a general UTF8 test

Summary

Ref T1191. After utf8mb4 conversion, these tests no longer pass because MySQL allows emoji and gclefs and such.

We could keep these tests running by keeping a ut8f_bin table around somewhere, but we have no other use cases for it and it does not seem worth the added complexity. All these BMP-only codepaths are on the way out.

Update the %s / %B test to make sure it's rejecting invalid byte sequences, which are still not permitted.

Test Plan

Tests now pass.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25501.Oct 2 2014, 3:31 PM

epriestley retitled this revision from to Remove UTF8 BMP unit test and replace it with a general UTF8 test.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 3:31 PM

Harbormaster completed remote builds in B2719: Diff 25501.Oct 2 2014, 3:32 PM

btrahan accepted this revision.Oct 2 2014, 4:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2014, 4:38 PM

Closed by commit rP410c2ecbfdf7: Remove UTF8 BMP unit test and replace it with a general UTF8 test (authored by epriestley, committed by epriestley).Oct 2 2014, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__tests__/

PhabricatorInfrastructureTestCase.php

57 lines

Diff 25515

View Options

src/tests/PhabricatorInfrastructureTestCase.php

Remove UTF8 BMP unit test and replace it with a general UTF8 testClosedPublicActions