Use `sort`, not `text`, for search index table
ClosedPublic
Actions

Authored by epriestley on Oct 1 2014, 8:11 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rPe4e5a2004fe0: Use `sort`, not `text`, for search index table

Summary

Ref T1191. The index's case sensitivity depends on the column type. Using text makes the search case-sensitive, which is not desirable.

Test Plan

After adjustment, searched for "PROJECTS" and found hits against "projects".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25496.Oct 1 2014, 8:11 PM

epriestley retitled this revision from to Use `sort`, not `text`, for search index table.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 1 2014, 8:11 PM

Harbormaster completed remote builds in B2714: Diff 25496.Oct 1 2014, 8:12 PM

This revision is now accepted and ready to land.Oct 2 2014, 4:32 PM

Closed by commit rPe4e5a2004fe0: Use `sort`, not `text`, for search index table (authored by epriestley, committed by epriestley).Oct 2 2014, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

storage/

document/

PhabricatorSearchDocumentField.php

2 lines

Diff 25511

View Options

src/applications/search/storage/document/PhabricatorSearchDocumentField.php

Use `sort`, not `text`, for search index tableClosedPublicActions