Page MenuHomePhabricator

Make `#?` work properly
ClosedPublic

Authored by epriestley on Oct 1 2014, 7:36 PM.
Tags
None
Referenced Files
F14063709: D10618.diff
Mon, Nov 18, 7:50 PM
F14052137: D10618.diff
Fri, Nov 15, 6:41 AM
F14039330: D10618.diff
Mon, Nov 11, 5:13 AM
F14024380: D10618.diff
Thu, Nov 7, 8:48 AM
F14012972: D10618.id25491.diff
Fri, Nov 1, 10:26 PM
F14000699: D10618.diff
Thu, Oct 24, 11:49 PM
F14000680: D10618.id.diff
Thu, Oct 24, 11:42 PM
F14000678: D10618.id25491.diff
Thu, Oct 24, 11:41 PM
Subscribers
Tokens
"Doubloon" token, awarded by btrahan.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6223: ?
Commits
Restricted Diffusion Commit
rPfda0b086b565: Make `#?` work properly
Summary

Ref T6223. Two issues:

  • We don't use /u mode on these regexps. Without /u, the \w/\W/\s/\S modifiers have bad behavior on non-ASCII bytes. Add the flag to use unicode mode, making \w and \s behave like we expect.
    • We might possibly want to do something different here eventually (for example, if the /u flag has some huge performance penalty) but this seems OK for now.
  • We use \b (word boundary) to terminate the match, but ? is not a word character. Use (?!\w) instead ("don't match before a word character") which is what we mean.
Test Plan

Screen_Shot_2014-10-01_at_12.32.53_PM.png (108×335 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make `#🐳` work properly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T6223: ?.
chad edited edge metadata.

???

This revision is now accepted and ready to land.Oct 1 2014, 7:40 PM
This revision was automatically updated to reflect the committed changes.