Page MenuHomePhabricator

Purge readthrough caches before applying schema adjustments

Authored by epriestley on Oct 1 2014, 5:08 PM.



Ref T1191. The bulk of the slowness in T1191 is copying tables. In some cases, we can't avoid this, but we have various readthrough caches which may be very large and are safe to drop, and dropping them is very quick (much less than 1 second). In particular, dropping the changeset_parse_cache made the process at least ~8 minutes faster on (I killed it after 8 minutes, so I'm not sure what the real number is).

Test Plan

Ran bin/storage adjust and saw it drop caches before applying adjustments.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Purge readthrough caches before applying schema adjustments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2014, 7:14 PM
This revision was automatically updated to reflect the committed changes.