Ref T1191. This fixes nearly every remaining blocker for utf8mb4 -- primarily, overlong keys.
Remaining issue is https://secure.phabricator.com/T1191#77467
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T6099: Key `key_token` on `phabricator_auth.auth_temporarytoken` is too long
T6129: `phabricator_conpherence.conpherence_transaction_comment` has overlong `key_draft` key
T6133: `phabricator_file.file_imagemacro` has a too-long key on `name`
T6134: `phabricator_file.file_transformedfile` has too-long key
T6150: `phabricator2_nuance.nuance_requestorsource` has overlong key
T6148: `phabricator2_metamta.metamta_mailinglist` has multiple overlong keys
T6147: `phabricator_metamta.metamta_mail` has overlong `status` key
T6146: `phabricator2_meta_data.patch_status` has overlong key
T6105: `phabricator_repository.repository_commitdata` authorName field should be longtext
T1191: Comments are truncated at first non-base-plane character - Commits
- Restricted Diffusion Commit
rP4fcc634a99dc: Fix almost all remaining schemata issues
I'll annotate inline.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/auth/storage/PhabricatorAuthProviderConfig.php | ||
|---|---|---|
| 35 | We control this, and it's never more than 32 characters long. | |
| src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php | ||
| 18 | We control this. The longest method name we have is about 40 characters. | |
| src/applications/config/schema/PhabricatorConfigColumnSchema.php | ||
| 65–77 | Compensates for CHARACTER SET binary being sort of imaginary. | |
| src/applications/config/schema/PhabricatorConfigKeySchema.php | ||
| 98–103 | We now detect overlong keys as a normal issue. Mostly, this allows us to remove them before making schema changes so they don't block column type changes. I also added FULLTEXT support since we needed it to avoid removing the FULLTEXT index. | |
| src/applications/config/schema/PhabricatorConfigTableSchema.php | ||
| 48–54 | Fixes a bug with HeraldTranscript which had keys and columns with the same name. | |
| src/applications/differential/storage/DifferentialDiffProperty.php | ||
| 15 | We control this and the longest string is fairly short. | |
| src/applications/files/storage/PhabricatorTransformedFile.php | ||
| 12 | We control this and never use more than ~50 characters. | |
| src/applications/herald/controller/HeraldRuleController.php | ||
| 324–333 | Long ago, Herald required each rule name to be unique (sort of). We now have the Hxx disambiguation and can just drop this. | |
| src/applications/herald/storage/HeraldRule.php | ||
| 39 | We control this and it's always short. | |
| 48–56 | General cleanup:
| |
| src/applications/herald/storage/transcript/HeraldTranscript.php | ||
| 109 | This was shadowed by a key of the same name. | |
| src/applications/mailinglists/storage/PhabricatorMetaMTAMailingList.php | ||
| 21–23 | It seems reasonable that no mailing list will have a name or address longer than 128 characters. | |
| src/applications/metamta/storage/PhabricatorMetaMTAMail.php | ||
| 36 | We control this and it's always short. | |
| src/applications/owners/storage/PhabricatorOwnersPackage.php | ||
| 42 | Eventually we should probably not require this to be unique, but for now it seems reasonable that packages probably don't have names longer than 128 characters. | |
| src/applications/people/storage/PhabricatorExternalAccount.php | ||
| 47 | We don't control this but it's unlikely that any provider has ids longer than 64 characters. | |
| src/applications/people/storage/PhabricatorUserSchemaSpec.php | ||
| 29 | This isn't unique so just index the first part. | |
| src/applications/phragment/storage/PhragmentFragment.php | ||
| 18 | Prototype app, only affects @hach-que. | |
| src/applications/phragment/storage/PhragmentSnapshot.php | ||
| 15 | As above. | |
| src/applications/phriction/storage/PhrictionContent.php | ||
| 54 | This was shortened to the same length as the document's slug column. Adjust the key. | |
| src/applications/project/storage/PhabricatorProject.php | ||
| 125 | Seems reasonable that no one has project names longer than 255 characters. | |
| src/applications/releeph/storage/ReleephProject.php | ||
| 33 | Prototype app, seems reasonable. | |
| src/applications/repository/storage/PhabricatorRepository.php | ||
| 100 | Nonunique, just index the first bit. | |
| src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php | ||
| 26 | Seems reasonable. | |
| src/applications/repository/storage/PhabricatorRepositoryBranch.php | ||
| 12 | Seems reasonable. This is only used by the saved-lint feature which is hard to use anyway. | |
| src/applications/repository/storage/PhabricatorRepositoryCommitData.php | ||
| 23 | See T6105, plus the key is useles. | |
| src/applications/repository/storage/PhabricatorRepositorySchemaSpec.php | ||
| 18 | You could only hit 64 characters with a 23-character callsign, and there's no UI for this table. | |
| src/applications/search/storage/document/PhabricatorSearchDocumentField.php | ||
| 25–28 | Explicitly mark this fulltext. | |
| src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php | ||
| 20–22 | We control these and they're alwasy short. | |
| src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php | ||
| 201–235 | Various keys need different grammar. | |
| 271 | derpalerp | |
| src/infrastructure/storage/schema/PhabricatorStorageSchemaSpec.php | ||
| 11 | We control this and they're always short. | |
Comment Actions
Some of these column shortenings may hit issues on user installs, but the design of this migration means that's perfectly fine. All other schema changes will apply cleanly and we can help them fix the issues and/or provide tools to sort the things out, without totaling installs in the meantime.
Slightly later on this patch series I'll also regenerate quickstart.sql so new installs never hit these issues.