Differential D10520

Drop old Audit tables; make markup cache binary
ClosedPublic
Actions

Authored by epriestley on Sep 18 2014, 6:08 PM.

Tags

None

Referenced Files

	F14027344: D10520.id25289.diff
	Fri, Nov 8, 6:39 AM

	F14010399: D10520.id25289.diff
	Thu, Oct 31, 7:24 AM

	F13997337: D10520.diff
	Thu, Oct 24, 3:48 AM

	F13973538: D10520.diff
	Oct 18 2024, 1:19 AM

	Unknown Object (File)
	Oct 10 2024, 10:17 PM

	Unknown Object (File)
	Oct 10 2024, 10:16 PM

	Unknown Object (File)
	Oct 10 2024, 10:16 PM

	Unknown Object (File)
	Oct 10 2024, 10:04 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6096: Remove `phabricator_audit.audit_comment` table
T6100: `phabricator_cache.cache_markupcache` stores PHP serialized blobs in a text column
T6097: Remove `phabricator_audit.audit_inlinecomment` table
T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rP263dbe7bfe8e: Drop old Audit tables; make markup cache binary

Summary

Ref T1191.

Fixes T6096. We've migrated away from this table in T4896. The data is now in the transaction table. There have been no reads or writes to this table for some time and I haven't seen any issues from users.
Fixes T6097. Same deal as above. The data is now in the transaction comment table.
Fixes T6100. This cache is safe to wipe out, since it's purely read-through. Wiping it will make the migration faster. The column type change fixes storage of PHP serialized objects in a text column.

Test Plan

Ran migrations.
Observed some yellow go blue on the Database Status screen.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25281.Sep 18 2014, 6:08 PM

epriestley retitled this revision from to Drop old Audit tables; make markup cache binary.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T1191: Comments are truncated at first non-base-plane character, T6097: Remove `phabricator_audit.audit_inlinecomment` table, T6100: `phabricator_cache.cache_markupcache` stores PHP serialized blobs in a text column, T6096: Remove `phabricator_audit.audit_comment` table.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 18 2014, 6:08 PM

Harbormaster completed remote builds in B2582: Diff 25281.Sep 18 2014, 6:09 PM

btrahan accepted this revision.Sep 18 2014, 6:09 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 18 2014, 6:09 PM

Closed by commit rP263dbe7bfe8e: Drop old Audit tables; make markup cache binary (authored by epriestley, committed by epriestley).Sep 19 2014, 12:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140918.schema.1.dropaudit.sql

1 line

20140918.schema.2.dropauditinline.sql

1 line

20140918.schema.3.wipecache.sql

1 line

20140918.schema.4.cachetype.sql

2 lines

Diff 25289

resources/sql/autopatches/20140918.schema.1.dropaudit.sql

Loading...

resources/sql/autopatches/20140918.schema.2.dropauditinline.sql

Loading...

resources/sql/autopatches/20140918.schema.3.wipecache.sql

Loading...

resources/sql/autopatches/20140918.schema.4.cachetype.sql

Loading...