Details

Reviewers

btrahan
chad

Maniphest Tasks

T6084: Hide Harbormaster / Drydock more, or warn users more about using them

Commits

Restricted Diffusion Commit
rP298604c9d35d: Rename "beta" to "prototype" and document support policy

Summary

Fixes T6084. Changes:

Rename phabricator.show-beta-applications to phabricator.show-prototypes, to reinforce that these include early-development applications.
Migrate the config setting.
Add an explicit "no support" banner to the config page.
Rename "Beta" to "Prototype" in the UI.
Use "bomb" icon instead of "half star" icon.
Document prototype applications in more detail.
Explicitly document that we do not support these applications.

Test Plan

Ran migration.
Resolved "obsolete config" issue.
Viewed config setting.
Browsed prototypes in Applications app.
Viewed documentation.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25218.Sep 14 2014, 4:37 PM

epriestley retitled this revision from to Rename "beta" to "prototype" and document support policy.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T6084: Hide Harbormaster / Drydock more, or warn users more about using them.

Herald added subscribers: hach-que, epriestley. · View Herald TranscriptSep 14 2014, 4:37 PM

Harbormaster completed remote builds in B2533: Diff 25218.Sep 14 2014, 4:38 PM

On application detail screen, link "Prototype" property to prototype docs.

Harbormaster completed remote builds in B2534: Diff 25219.Sep 14 2014, 4:41 PM

Looks good to me.

src/applications/config/check/PhabricatorSetupCheckExtraConfig.php
196	"existing"

hach-que added inline comments.Sep 14 2014, 4:46 PM

src/applications/config/option/PhabricatorCoreConfigOptions.php

114

This renders as:

To learn more about prototypes, see <a href="https://secure.phabricator.com/diviner/find/?name=User+Guide%3A+Prototype+Applications&amp;type=article&amp;jump=1" target="_blank" rel="noreferrer">User Guide: Prototype Applications</a>.

Add "general interest" to feedback, since this is also useful.

Harbormaster completed remote builds in B2535: Diff 25220.Sep 14 2014, 4:50 PM

Fix "existing" typo.

Harbormaster completed remote builds in B2536: Diff 25221.Sep 14 2014, 4:50 PM

This renders as:

Obviously intended, to reinforce the prototype nature of these applications!

Other than the link rendering, this works as intended (from a technical standpoint anyway).

This revision is now accepted and ready to land.Sep 14 2014, 4:53 PM

Fix link in config help text.
Label the options "Enable/Disable Prototypes" instead of "Install/Uninstall Prototypes", to make the distinction between this and the "Install" action more clear.

This revision now requires review to proceed.Sep 14 2014, 4:53 PM

Harbormaster completed remote builds in B2537: Diff 25222.Sep 14 2014, 4:53 PM

That removal was a race condition but I'm not going to file it until I hit it again or some other user hits it, that's the first time I've seen it, it's pretty minor, and it's not really avoidable in the general case with --edit.

btrahan accepted this revision.Sep 16 2014, 6:30 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/config/option/PhabricatorCoreConfigOptions.php
109	because they are often not
src/docs/user/userguide/prototypes.diviner
45	Maybe add something here or a third bullet like "NOTE: We may not respond to you until we reach the point in prototype development where the feedback becomes relevant."

This revision is now accepted and ready to land.Sep 16 2014, 6:30 PM

Closed by commit rP298604c9d35d: Rename "beta" to "prototype" and document support policy (authored by epriestley, committed by epriestley).Sep 18 2014, 1:26 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T6797: Phabricator user group.Dec 28 2014, 7:17 PM

Rename "beta" to "prototype" and document support policy
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25253

conf/default.conf.php

resources/celerity/map.php

resources/sql/autopatches/20140914.betaproto.php

src/applications/base/PhabricatorApplication.php

src/applications/calendar/application/PhabricatorCalendarApplication.php

src/applications/chatlog/application/PhabricatorChatLogApplication.php

src/applications/config/check/PhabricatorSetupCheckExtraConfig.php

src/applications/config/option/PhabricatorCoreConfigOptions.php

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

src/applications/drydock/application/PhabricatorDrydockApplication.php

src/applications/fact/application/PhabricatorFactApplication.php

src/applications/fund/application/PhabricatorFundApplication.php

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

src/applications/meta/query/PhabricatorAppSearchEngine.php

src/applications/meta/query/PhabricatorApplicationQuery.php

src/applications/meta/view/PhabricatorApplicationLaunchView.php

src/applications/nuance/application/PhabricatorNuanceApplication.php

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

src/applications/phame/application/PhabricatorPhameApplication.php

src/applications/phlux/application/PhabricatorPhluxApplication.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phragment/application/PhabricatorPhragmentApplication.php

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

src/applications/ponder/application/PhabricatorPonderApplication.php

src/docs/user/userguide/prototypes.diviner

src/infrastructure/testing/PhabricatorTestCase.php

webroot/rsrc/css/application/base/phabricator-application-launch-view.css

Rename "beta" to "prototype" and document support policyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25253

conf/default.conf.php

resources/celerity/map.php

resources/sql/autopatches/20140914.betaproto.php

src/applications/base/PhabricatorApplication.php

src/applications/calendar/application/PhabricatorCalendarApplication.php

src/applications/chatlog/application/PhabricatorChatLogApplication.php

src/applications/config/check/PhabricatorSetupCheckExtraConfig.php

src/applications/config/option/PhabricatorCoreConfigOptions.php

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

src/applications/drydock/application/PhabricatorDrydockApplication.php

src/applications/fact/application/PhabricatorFactApplication.php

src/applications/fund/application/PhabricatorFundApplication.php

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

src/applications/meta/query/PhabricatorAppSearchEngine.php

src/applications/meta/query/PhabricatorApplicationQuery.php

src/applications/meta/view/PhabricatorApplicationLaunchView.php

src/applications/nuance/application/PhabricatorNuanceApplication.php

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

src/applications/phame/application/PhabricatorPhameApplication.php

src/applications/phlux/application/PhabricatorPhluxApplication.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phragment/application/PhabricatorPhragmentApplication.php

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

src/applications/ponder/application/PhabricatorPonderApplication.php

src/docs/user/userguide/prototypes.diviner

src/infrastructure/testing/PhabricatorTestCase.php

webroot/rsrc/css/application/base/phabricator-application-launch-view.css

Rename "beta" to "prototype" and document support policy
ClosedPublic
Actions

Revision Contents
Changeset List