Page MenuHomePhabricator
Differential D10487

Differential - label unit / lint results from the commit diff as not applicable
ClosedPublic
Actions

Authored by btrahan on Sep 12 2014, 5:22 PM.
Tags
None
Referenced Files
F15468922: D10487.diff
Fri, Apr 4, 7:46 AM
F15467009: D10487.id25210.diff
Thu, Apr 3, 11:43 AM
F15446259: D10487.id.diff
Thu, Mar 27, 6:02 PM
F15433201: D10487.diff
Mon, Mar 24, 10:01 PM
F15418634: D10487.id25210.diff
Fri, Mar 21, 12:33 AM
F15415105: D10487.id25238.diff
Thu, Mar 20, 4:01 AM
F15412189: D10487.id.diff
Wed, Mar 19, 11:45 AM
F15407523: D10487.diff
Tue, Mar 18, 6:05 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Love" token, awarded by hach-que.

Details

Reviewers
epriestley
Maniphest Tasks
T5536: Automatic diff should be more clearly called out in the UI
Commits
Restricted Diffusion Commit
rP936ee22de1b8: Differential - label unit / lint results from the commit diff as not applicable
Summary

Fixes T5536. Some bonus pht in there.

Test Plan

made a diff hovered over the stars and saw my new text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25210.Sep 12 2014, 5:22 PM
btrahan added a task: T5536: Automatic diff should be more clearly called out in the UI.
btrahan retitled this revision from to Differential - label unit / lint results from the commit diff as not applicable.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 12 2014, 5:22 PM
Harbormaster completed remote builds in B2526: Diff 25210.Sep 12 2014, 5:23 PM
epriestley accepted this revision.Sep 14 2014, 2:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 14 2014, 2:04 PM
hach-que awarded a token.Sep 14 2014, 3:03 PM
Closed by commit rP936ee22de1b8: Differential - label unit / lint results from the commit diff as not applicable (authored by btrahan, committed by btrahan).Sep 16 2014, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
1 line
1 line
customfield/
3 lines
2 lines
view/
31 lines
repository/
worker/
commitmessageparser/
4 lines

Diff 25238

View Options

src/applications/differential/constants/DifferentialLintStatus.php

Loading...
View Options

src/applications/differential/constants/DifferentialUnitStatus.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility