Paths

Table of Contentst

Provide more information from diffusion.querycommits
ClosedPublic
Actions

Authored by epriestley on Sep 5 2014, 1:41 PM.

Details

Reviewers

Maniphest Tasks

T2783: Make working-copy operations service-oriented
T6039: Add authorPHID, committerPHID and pusherPHID to the results returned by diffusion.querycommits

Commits

Restricted Diffusion Commit
rPac4247ea59eb: Provide more information from diffusion.querycommits

Summary

Ref T2783. Fixes T6039.

Provide authorPHID and committerPHID to resolve T6039.
In message parser, store author/email strings.
In cached results, emit author/email strings.

Test Plan

Called method with and without bypassCache. Used reparse.php to repopulate data on an old commit.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25077.Sep 5 2014, 1:41 PM

epriestley retitled this revision from to Provide more information from diffusion.querycommits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T6039: Add authorPHID, committerPHID and pusherPHID to the results returned by diffusion.querycommits, T2783: Make working-copy operations service-oriented.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 5 2014, 1:41 PM

Harbormaster completed remote builds in B2442: Diff 25077.Sep 5 2014, 1:41 PM

btrahan accepted this revision.Sep 5 2014, 5:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 5 2014, 5:44 PM

Closed by commit rPac4247ea59eb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryCommitsConduitAPIMethod.php

32 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

8 lines

Diff 25085

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php