Page MenuHomePhabricator
Differential D10424

Provide more information from diffusion.querycommits
ClosedPublic
Actions

Authored by epriestley on Sep 5 2014, 1:41 PM.
Tags
None
Referenced Files
F15468841: D10424.diff
Fri, Apr 4, 6:32 AM
F15380695: D10424.id25085.diff
Fri, Mar 14, 4:08 AM
F15336408: D10424.diff
Sat, Mar 8, 6:47 PM
Unknown Object (File)
Feb 23 2025, 4:50 PM
Unknown Object (File)
Feb 13 2025, 12:42 AM
Unknown Object (File)
Feb 11 2025, 10:42 PM
Unknown Object (File)
Feb 7 2025, 10:58 PM
Unknown Object (File)
Feb 7 2025, 10:58 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2783: Make working-copy operations service-oriented
T6039: Add authorPHID, committerPHID and pusherPHID to the results returned by diffusion.querycommits
Commits
Restricted Diffusion Commit
rPac4247ea59eb: Provide more information from diffusion.querycommits
Summary

Ref T2783. Fixes T6039.

  • Provide authorPHID and committerPHID to resolve T6039.
  • In message parser, store author/email strings.
  • In cached results, emit author/email strings.
Test Plan

Called method with and without bypassCache. Used reparse.php to repopulate data on an old commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25077.Sep 5 2014, 1:41 PM
epriestley retitled this revision from to Provide more information from diffusion.querycommits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T6039: Add authorPHID, committerPHID and pusherPHID to the results returned by diffusion.querycommits, T2783: Make working-copy operations service-oriented.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 5 2014, 1:41 PM
Harbormaster completed remote builds in B2442: Diff 25077.Sep 5 2014, 1:41 PM
btrahan accepted this revision.Sep 5 2014, 5:44 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 5:44 PM
epriestley closed this revision.Sep 5 2014, 7:28 PM
epriestley updated this revision to Diff 25085.

Closed by commit rPac4247ea59eb (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
32 lines
repository/
worker/
commitmessageparser/
8 lines

Diff 25085

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility