Paths

Table of Contentst

Use %s, not %d, to encode a 64-bit integer for a query
ClosedPublic
Actions

Authored by epriestley on Sep 4 2014, 6:02 PM.

Tags

None

Referenced Files

	F15466922: D10415.id25062.diff
	Thu, Apr 3, 10:52 AM

	F15432091: D10415.id25062.diff
	Mon, Mar 24, 4:01 PM

	F15416834: D10415.diff
	Thu, Mar 20, 1:54 PM

	F15383645: D10415.id25059.diff
	Fri, Mar 14, 5:27 PM

	F15354102: D10415.id25058.diff
	Tue, Mar 11, 1:56 AM

	Unknown Object (File)
	Feb 13 2025, 10:42 AM

	Unknown Object (File)
	Feb 12 2025, 6:52 AM

	Unknown Object (File)
	Feb 12 2025, 6:52 AM

View All Files

Subscribers

epriestley

Tokens

"Grey Medal" token, awarded by btrahan.

Details

Reviewers

btrahan

Maniphest Tasks

T5982: Notifications: "Mark all Read" not clearing unread notifications list

Commits

Restricted Diffusion Commit
rP4d3cc7b28dd1: Use %s, not %d, to encode a 64-bit integer for a query

Summary

Fixes T5982. Probably. I'm just guessing here but like 95% sure this will fix it and 99% sure it won't hurt/break anything.

Test Plan

Still works on my 64-bit install, for what little that's worth.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25058.Sep 4 2014, 6:02 PM

epriestley retitled this revision from to Use %s, not %d, to encode a 64-bit integer for a query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5982: Notifications: "Mark all Read" not clearing unread notifications list.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 4 2014, 6:02 PM

Harbormaster completed remote builds in B2432: Diff 25058.Sep 4 2014, 6:03 PM

Use getStr() instead of getInt() for good measure.

iiam

Harbormaster completed remote builds in B2433: Diff 25059.Sep 4 2014, 6:04 PM

btrahan accepted this revision.Sep 4 2014, 6:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 4 2014, 6:38 PM

btrahan awarded a token.Sep 4 2014, 6:41 PM

Closed by commit rP4d3cc7b28dd1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

controller/

PhabricatorNotificationClearController.php

4 lines

Diff 25062

View Options

src/applications/notification/controller/PhabricatorNotificationClearController.php

Use %s, not %d, to encode a 64-bit integer for a queryClosedPublicActions