Differential D10414

Allow Passphrase to store empty secrets
ClosedPublic
Actions

Authored by epriestley on Sep 4 2014, 5:55 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6001: Subversion requires password, or dies with “Expected PhutilOpaqueEnvelope for %P conversion”

Commits

Restricted Diffusion Commit
rPa6296a64a457: Allow Passphrase to store empty secrets

Summary

Fixes T6001. We currently don't allow empty secrets, but accounts with no password are occasionally used in the wild.

Test Plan

Created a credential with an empty secret.
Revealed secret, saw empty message.
Edited it (no form changes), saw secret unchanged.
Changed it to a nonempty secret.
Revealed nonempty secret.
Edited it (no form changes), saw secret unchanged.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25057.Sep 4 2014, 5:55 PM

epriestley retitled this revision from to Allow Passphrase to store empty secrets.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6001: Subversion requires password, or dies with “Expected PhutilOpaqueEnvelope for %P conversion”.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 4 2014, 5:55 PM

Harbormaster completed remote builds in B2431: Diff 25057.Sep 4 2014, 5:55 PM

btrahan accepted this revision.Sep 4 2014, 7:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 4 2014, 7:28 PM

Closed by commit rPa6296a64a457 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

controller/

PassphraseCredentialEditController.php

9 lines

PassphraseCredentialRevealController.php

11 lines

Diff 25065

View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php