Page MenuHomePhabricator

Allow Passphrase to store empty secrets
ClosedPublic

Authored by epriestley on Sep 4 2014, 5:55 PM.

Details

Summary

Fixes T6001. We currently don't allow empty secrets, but accounts with no password are occasionally used in the wild.

Test Plan
  • Created a credential with an empty secret.
  • Revealed secret, saw empty message.
  • Edited it (no form changes), saw secret unchanged.
  • Changed it to a nonempty secret.
  • Revealed nonempty secret.
  • Edited it (no form changes), saw secret unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow Passphrase to store empty secrets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:28 PM
epriestley updated this revision to Diff 25065.

Closed by commit rPa6296a64a457 (authored by @epriestley).