Page MenuHomePhabricator
Differential D10399

Populate results of DiffusionQueryCommitsConduitAPIMethod with DiffusionLowLevelCommitQuery
ClosedPublic
Actions

Authored by hach-que on Sep 2 2014, 8:07 AM.
Tags
None
Referenced Files
F13099633: D10399.id25038.diff
Fri, Apr 26, 3:46 PM
F13099629: D10399.id25037.diff
Fri, Apr 26, 3:46 PM
F13099628: D10399.id25023.diff
Fri, Apr 26, 3:46 PM
F13099627: D10399.id.diff
Fri, Apr 26, 3:45 PM
Unknown Object (File)
Thu, Apr 25, 1:16 PM
Unknown Object (File)
Thu, Apr 25, 1:14 AM
Unknown Object (File)
Mon, Apr 22, 5:24 PM
Unknown Object (File)
Thu, Apr 11, 8:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2783: Make working-copy operations service-oriented
Commits
Restricted Diffusion Commit
rPd7f51325e3ab: Populate results of DiffusionQueryCommitsConduitAPIMethod with…
Summary

Ref T2783. This populates the following fields in DiffusionQueryCommitsConduitAPIMethod using DiffusionLowLevelCommitQuery when bypassCache is set to true:

  • authorName
  • authorEmail
  • committerName
  • committerEmail
  • message
  • hashes

The original outline called for authorPHID and committerPHID as well (but no message field). As far as I can tell, the PHIDs aren't actual a property on DiffusionCommitRef, and since the intention of this is to be able to populate a DiffusionCommitRef, I haven't included them. Let me know if we really do need the PHIDs here.

Test Plan

Tested using 3 Phabricator instances (one web, one taskmaster and one storage). The web and taskmaster tiers are directed at the Conduit API of the storage tier. Made a diffusion.querycommits from the Conduit app on the web tier instance and saw the data populated from the raw VCS data (located on the storage tier).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 25023.Sep 2 2014, 8:07 AM
hach-que retitled this revision from to Populate results of DiffusionQueryCommitsConduitAPIMethod with DiffusionLowLevelCommitQuery.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2783: Make working-copy operations service-oriented.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 2 2014, 8:07 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2407: Diff 25023.Sep 2 2014, 8:08 AM
epriestley accepted this revision.Sep 3 2014, 1:14 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php
96

For consistency, maybe omit this?

109

And provide this only if needMessages is true?

Basically, only return message as a key if needMessages is specified.

This revision is now accepted and ready to land.Sep 3 2014, 1:14 AM
hach-que updated this revision to Diff 25037.Sep 3 2014, 12:37 PM
hach-que edited edge metadata.

Changes requested in code review

Harbormaster completed remote builds in B2418: Diff 25037.Sep 3 2014, 12:38 PM
hach-que closed this revision.Sep 3 2014, 12:54 PM
hach-que updated this revision to Diff 25038.

Closed by commit rPd7f51325e3ab (authored by @hach-que).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
29 lines

Diff 25038

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility