Page MenuHomePhabricator

Daemons - handle daemons that can't be killed a bit better
ClosedPublic

Authored by btrahan on Aug 29 2014, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 1:56 PM
Unknown Object (File)
Feb 16 2024, 9:58 AM
Unknown Object (File)
Feb 16 2024, 9:58 AM
Unknown Object (File)
Jan 31 2024, 1:31 AM
Unknown Object (File)
Jan 30 2024, 1:32 PM
Unknown Object (File)
Jan 22 2024, 11:59 PM
Unknown Object (File)
Jan 15 2024, 3:24 PM
Unknown Object (File)
Jan 8 2024, 8:21 PM
Subscribers

Details

Summary

Ref T2374. Fixes T5988.

Keep track of what's been killed and not been killed, and surface that maybe you need sudo if things don't get killed with --force

...also basically make this force thing work. I managed to convinced myself stuff was getting killed with --force when it mostly wasn't. Make sure the --force parameter gets pushed as low as it needs to go to have things get killed.

Test Plan
  • sudo ./bin/phd restart
  • rm -rf /var/tmp/phd/pid/*
  • ./bin/phd stop --> get warning about rogue daemons
  • ./bin/phd stop X --> get warning about no running daemons
  • ./bin/phd stop --force --> get warning about not being able to kill daemons
  • sudo ./bin/phd stop --force --> kill daemons successfully

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Daemons - handle daemons that can't be killed a bit better.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2014, 9:24 PM
btrahan updated this revision to Diff 25045.

Closed by commit rP7ecbc707846f (authored by @btrahan).