Page MenuHomePhabricator

Fix broken XHProf unit tests
ClosedPublic

Authored by epriestley on Aug 27 2014, 11:46 PM.
Tags
None
Referenced Files
F13082989: D10376.diff
Wed, Apr 24, 10:23 PM
Unknown Object (File)
Thu, Apr 11, 7:33 AM
Unknown Object (File)
Wed, Apr 3, 1:31 PM
Unknown Object (File)
Sun, Mar 31, 2:17 PM
Unknown Object (File)
Sat, Mar 30, 7:24 AM
Unknown Object (File)
Thu, Mar 28, 6:37 AM
Unknown Object (File)
Mar 24 2024, 6:19 AM
Unknown Object (File)
Mar 23 2024, 11:13 AM
Subscribers

Details

Summary

There are two broken tests. One (007) is easy to fix. It was failing because of array-to-string conversion warnings.

Since I didn't want to add function calls because that would change the test output, I just silenced the warnings with "@".

The other test (004) was also easy to fix but I can't really explain what's going on there. Seems like it works though? It shouldn't do anything bad, since we would have generated a meaningless "???_op" otherwise.

Test Plan

Ran tests, tests passed.

Diff Detail

Repository
rXPRF XHProf
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix broken XHProf unit tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Add a cleaner and more correct fix for the 007 test.
This revision is now accepted and ready to land.Aug 28 2014, 5:24 PM
epriestley updated this revision to Diff 24985.

Closed by commit rXPRF91e0be91da03 (authored by @epriestley).