Page MenuHomePhabricator

Daemons - better handle rogue daemons from phd
ClosedPublic

Authored by btrahan on Aug 27 2014, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 5:54 AM
Unknown Object (File)
Feb 28 2024, 10:54 AM
Unknown Object (File)
Feb 10 2024, 3:03 AM
Unknown Object (File)
Feb 9 2024, 4:54 PM
Unknown Object (File)
Feb 2 2024, 1:31 AM
Unknown Object (File)
Feb 2 2024, 1:31 AM
Unknown Object (File)
Feb 2 2024, 1:31 AM
Unknown Object (File)
Jan 30 2024, 3:11 PM
Subscribers

Details

Summary

Ref T2374. While building D10367 I noticed that phd was finding rogue daemons way more than it should be. Re-jigger this code path so rogue daemons are checked for *after* we've dealt with known daemons. This keeps the logic pretty simple overall.

Test Plan

phd start; kill pid files; phd stop and get the right warning; phd stop --force and it kills the rogue demons. phd stop in normal conditions no longer reporting rogue daemons erroneously

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Daemons - better handle rogue daemons from phd.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Ah, nice. I saw this too.

One other thing I hit is that bin/phd stop <pid> checks for rogues, but probably should not, since the user is trying to surgically stop a specific PID.

This revision is now accepted and ready to land.Aug 27 2014, 7:12 PM
btrahan edited edge metadata.

only show stop hint for rogue daemons if user did not specify $pids

btrahan updated this revision to Diff 24959.

Closed by commit rP2fdd7f0f3d2e (authored by @btrahan).