Page MenuHomePhabricator

Remove Composer support from XHProf
ClosedPublic

Authored by epriestley on Aug 27 2014, 5:08 PM.
Tags
None
Referenced Files
F15455784: D10365.diff
Sun, Mar 30, 4:50 AM
F15396572: D10365.id.diff
Sun, Mar 16, 3:10 PM
F15391452: D10365.diff
Sat, Mar 15, 9:55 AM
F15352593: D10365.id24953.diff
Mon, Mar 10, 5:21 PM
Unknown Object (File)
Feb 24 2025, 5:25 PM
Unknown Object (File)
Jan 31 2025, 8:32 AM
Unknown Object (File)
Jan 26 2025, 5:29 AM
Unknown Object (File)
Jan 18 2025, 12:10 AM
Subscribers
Tokens
"The World Burns" token, awarded by btrahan.

Details

Summary

See https://github.com/phacility/xhprof/pull/40. This is currently broken and extremely insecure.

We may want to restore it eventually, but understanding composer is very complex (no one who touched this realized that the package was owned by someone unrelated to the project who can apparently redirect it at will with no accountability). No one on the ticket seems to have any reason why this isn't totally wide open, and I haven't gotten in touch with anyone in #composer-dev.

Test Plan

N/A

Diff Detail

Repository
rXPRF XHProf
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove Composer support from XHProf.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan awarded a token.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 27 2014, 5:15 PM
epriestley updated this revision to Diff 24953.

Closed by commit rXPRFe3df210a649b (authored by @epriestley).