Detect ft_stopword_file being unsupported
ClosedPublic
Actions

Authored by epriestley on Aug 25 2014, 1:59 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2605: Search on secure.phabricator.com doesn't find MySQL stopwords

Commits

Restricted Diffusion Commit
rP3275d80cf9a8: Detect ft_stopword_file being unsupported

Summary

Ref T2605. For old MySQL, this option is not supported. Catch that and tailor the error.

I couldn't find the first version of MySQL which introduced this optino in order to produce a more useful error. I spent about ~10 minutes looking.

Test Plan

Faked the error, survived setup.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24899.Aug 25 2014, 1:59 PM

epriestley retitled this revision from to Detect ft_stopword_file being unsupported.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2605: Search on secure.phabricator.com doesn't find MySQL stopwords.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 25 2014, 1:59 PM

Harbormaster completed remote builds in B2337: Diff 24899.Aug 25 2014, 2:00 PM

chad accepted this revision.Aug 25 2014, 2:28 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Aug 25 2014, 2:28 PM

Closed by commit rP3275d80cf9a8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorSetupCheckMySQL.php

32 lines

Diff 24902

View Options

src/applications/config/check/PhabricatorSetupCheckMySQL.php

Detect ft_stopword_file being unsupportedClosedPublicActions