Page MenuHomePhabricator
Differential D10316

Allow pre-commit adapter to use custom actions
ClosedPublic
Actions

Authored by hach-que on Aug 21 2014, 12:58 AM.
Tags
None
Referenced Files
F18119641: D10316.id24835.diff
Wed, Aug 13, 10:03 AM
F18086832: D10316.id24974.diff
Wed, Aug 6, 12:29 AM
F18086140: D10316.id24834.diff
Tue, Aug 5, 7:40 PM
F18082904: D10316.id.diff
Tue, Aug 5, 7:55 AM
F18082648: D10316.id24975.diff
Tue, Aug 5, 6:53 AM
F18074446: D10316.diff
Mon, Aug 4, 5:44 PM
F17831687: D10316.id.diff
Jul 26 2025, 12:10 PM
Unknown Object (File)
Jul 1 2025, 5:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2fd395e859bb: Allow pre-commit adapter to use custom actions
Summary

Looks like I missed this when implementing custom actions and hence you can't currently use custom actions on the pre-commit adapters.

Test Plan

Added a custom action to a pre-commit Herald rule.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24834.Aug 21 2014, 12:58 AM
hach-que retitled this revision from to Allow pre-commit adapter to use custom actions.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 21 2014, 12:58 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
hach-que planned changes to this revision.Aug 21 2014, 12:59 AM

Oops. Looks like that just fixes the UI; it doesn't fix the actual triggering of the actions.

Harbormaster completed remote builds in B2298: Diff 24834.Aug 21 2014, 12:59 AM
hach-que updated this revision to Diff 24835.Aug 21 2014, 1:02 AM
hach-que edited edge metadata.

Actually made it work :/

Harbormaster completed remote builds in B2299: Diff 24835.Aug 21 2014, 1:03 AM
epriestley accepted this revision.Aug 28 2014, 12:30 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/diffusion/herald/HeraldPreCommitAdapter.php
127

pht regression :o

This revision is now accepted and ready to land.Aug 28 2014, 12:30 AM
hach-que added inline comments.Aug 28 2014, 12:55 AM
src/applications/diffusion/herald/HeraldPreCommitAdapter.php
127

Ouch, these are missing pht in all the classes; I'll go fix the other adapters up as well.

hach-que updated this revision to Diff 24974.Aug 28 2014, 12:58 AM
hach-que edited edge metadata.

Fix pht() in other adapters as well

Harbormaster completed remote builds in B2379: Diff 24974.Aug 28 2014, 12:59 AM
hach-que closed this revision.Aug 28 2014, 12:59 AM
hach-que updated this revision to Diff 24975.

Closed by commit rP2fd395e859bb (authored by @hach-que).

Revision Contents
Changeset List

Diff 24975

View Options

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
Phabricator · Built by Phacility