Page MenuHomePhabricator

Allow moving task on the workboard to kick off both TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
Needs RevisionPublic

Authored by locutus on Aug 20 2014, 11:20 PM.
Tags
None
Attached Files
Unknown Object (File)
Apr 12 2017, 4:21 AM
Unknown Object (File)
Apr 7 2017, 10:45 PM
Unknown Object (File)
Apr 6 2017, 3:14 PM
Unknown Object (File)
Apr 2 2017, 2:17 AM
Unknown Object (File)
Mar 9 2017, 2:59 AM
Unknown Object (File)
Mar 4 2017, 6:35 PM
Unknown Object (File)
Mar 1 2017, 5:56 AM
Unknown Object (File)
Feb 28 2017, 6:27 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I noticed that moving a task on the workboard didn't cause an event to trigger that could be listened to. This will allow the transactions to be monitored via event listeners.

Test Plan
  • Make sure that all movements can still happen on the workboards.
  • Make sure it triggers events.

Diff Detail

Repository
rP Phabricator
Branch
workboard-move-event
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 2294
Build 2298: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

locutus retitled this revision from to Allow moving task on the workboard to kick off both TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events..
locutus updated this object.
locutus edited the test plan for this revision. (Show Details)

We'd generally like to move away from event listeners. Can you walk me through why you want this? Would T5474 cover your use case?

We want to have emails sent out when tasks are moved from one column to another. but Herald doesn't have a hook for Column moves. We were going to write our own listener to get that.

Can you walk me through your use case in more detail? What sort of column moves do you want to generate email? All of them? Moves to specific columns?

With T5474, "send an email to..." could conceivably be a column trigger action.

T5474 should cover our use cases, this diff was something we did in the meantime so that we can do things when things move to certain columns until T5474 happens.

epriestley added a reviewer: epriestley.

This will be obsoleted by T5474 and isn't something we're interested in upstreaming in advance of that.

This revision now requires changes to proceed.May 17 2015, 2:10 PM