Differential D10310

Remarkup - call pasted files "pasted_file" rather than "undefined"
ClosedPublic
Actions

Authored by btrahan on Aug 20 2014, 8:27 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5917: Pick a better filename than 'undefined' when copy/pasting images

Commits

Restricted Diffusion Commit
rP0ddafc4bcd83: Remarkup - call pasted files "pasted_file" rather than "undefined"

Summary

Fixes T5917. Turns out that pasted files don't get a name - "what is data on a clipboard anyway?" / see https://code.google.com/p/chromium/issues/detail?id=361145

Test Plan

pasted a file and got the slightly better name "pasted_file"

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24822.Aug 20 2014, 8:27 PM

btrahan added a task: T5917: Pick a better filename than 'undefined' when copy/pasting images.

btrahan retitled this revision from to Remarkup - call pasted files "pasted_file" rather than "undefined".

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 20 2014, 8:27 PM

Harbormaster completed remote builds in B2291: Diff 24822.Aug 20 2014, 8:28 PM

epriestley accepted this revision.Aug 20 2014, 9:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 9:00 PM

Closed by commit rP0ddafc4bcd83 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

core/

DragAndDropFileUpload.js

8 lines

Diff 24828

View Options

resources/celerity/map.php