Page MenuHomePhabricator
Differential D10309

Files - make file info page public
ClosedPublic
Actions

Authored by btrahan on Aug 20 2014, 8:13 PM.
Tags
None
Referenced Files
F13097528: D10309.id24820.diff
Fri, Apr 26, 1:08 AM
F13097527: D10309.id24818.diff
Fri, Apr 26, 1:08 AM
Unknown Object (File)
Wed, Apr 24, 11:40 PM
Unknown Object (File)
Mon, Apr 22, 5:10 AM
Unknown Object (File)
Tue, Apr 16, 8:19 PM
Unknown Object (File)
Tue, Apr 16, 9:46 AM
Unknown Object (File)
Wed, Apr 10, 2:51 AM
Unknown Object (File)
Sun, Apr 7, 3:24 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5922: File info page doesn't support public users
Commits
Restricted Diffusion Commit
rP8dd4d5cfe5e6: Files - make file info page public
Summary

and for bonus, finesse some URIs a tad. Fixes T5922.

Test Plan

viewed F1 logged out and it worked! viewed the ugly URI for F1 and got redirected to the pretty URI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24818.Aug 20 2014, 8:13 PM
btrahan added a task: T5922: File info page doesn't support public users.
btrahan retitled this revision from to Files - make file info page public.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 20 2014, 8:13 PM
epriestley accepted this revision.Aug 20 2014, 8:14 PM
epriestley edited edge metadata.

:3 :3

This revision is now accepted and ready to land.Aug 20 2014, 8:14 PM
Harbormaster completed remote builds in B2290: Diff 24818.Aug 20 2014, 8:14 PM
btrahan closed this revision.Aug 20 2014, 8:15 PM
btrahan updated this revision to Diff 24820.

Closed by commit rP8dd4d5cfe5e6 (authored by @btrahan).

Revision Contents
Changeset List

Diff 24820

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileShortcutController.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility