Login to Comment - kill intermediary dialogue
ClosedPublic
Actions

Authored by btrahan on Aug 19 2014, 6:52 PM.

Tags

None

Referenced Files

	F14057609: D10295.diff
	Sun, Nov 17, 5:11 AM

	F14012576: D10295.diff
	Fri, Nov 1, 2:51 PM

	F13991482: D10295.id.diff
	Tue, Oct 22, 11:08 AM

	F13962222: D10295.id24790.diff
	Oct 15 2024, 8:53 AM

	Unknown Object (File)
	Oct 13 2024, 11:52 AM

	Unknown Object (File)
	Oct 11 2024, 10:57 AM

	Unknown Object (File)
	Sep 4 2024, 11:50 AM

	Unknown Object (File)
	Sep 4 2024, 1:38 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5906: "Login to Comment" should lead to login screen

Commits

Restricted Diffusion Commit
rP20d6c7a04879: Login to Comment - kill intermediary dialogue

Summary

its not necessary. Fixes T5906

Test Plan

clicked "Login to Comment" and went straight to the login form, sans intermediary dialogue

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24790.Aug 19 2014, 6:52 PM

btrahan added a task: T5906: "Login to Comment" should lead to login screen.

btrahan retitled this revision from to Login to Comment - kill intermediary dialogue.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 19 2014, 6:52 PM

Harbormaster completed remote builds in B2272: Diff 24790.Aug 19 2014, 6:53 PM

epriestley accepted this revision.Aug 19 2014, 8:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2014, 8:59 PM

Closed by commit rP20d6c7a04879 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

1 line

Diff 24819

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Login to Comment - kill intermediary dialogueClosedPublicActions