Page MenuHomePhabricator

Create an index on harbormaster_buildlog to reduce page load times
ClosedPublic

Authored by hach-que on Aug 18 2014, 12:18 AM.
Tags
None
Referenced Files
F15458372: D10286.id24809.diff
Sun, Mar 30, 11:20 PM
F15458371: D10286.id24802.diff
Sun, Mar 30, 11:20 PM
F15458370: D10286.id24772.diff
Sun, Mar 30, 11:20 PM
F15438059: D10286.id24809.diff
Tue, Mar 25, 11:09 PM
F15437814: D10286.id.diff
Tue, Mar 25, 9:41 PM
F15437485: D10286.id24802.diff
Tue, Mar 25, 7:45 PM
F15435222: D10286.id24772.diff
Tue, Mar 25, 7:27 AM
F15431087: D10286.diff
Mon, Mar 24, 10:25 AM
Subscribers

Details

Summary

Resolves T5895. This reduces page load times significantly when looking at builds.

Test Plan

Viewed a build, saw the page load a lot faster.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Create an index on harbormaster_buildlog to reduce page load times.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
  • By convention, prefer to write this like other key patches (see below).
  • Prefer to provide an explicit key name.
  • Provide a database name explicitly.

I think this should work:

ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildlog
  ADD KEY `key_buildtarget` (buildTargetPHID);
This revision now requires changes to proceed.Aug 19 2014, 9:27 PM
hach-que edited edge metadata.

Update based on feedback

epriestley edited edge metadata.

Worked fine for me locally.

This revision is now accepted and ready to land.Aug 19 2014, 10:45 PM
hach-que updated this revision to Diff 24809.

Closed by commit rP6f85c22faffd (authored by @hach-que).