Page MenuHomePhabricator
Differential D10285

Modernize DatePicker
ClosedPublic
Actions

Authored by chad on Aug 16 2014, 9:31 PM.
Tags
None
Referenced Files
F14004447: D10285.id.diff
Sat, Oct 26, 8:41 PM
F13996338: D10285.id24769.diff
Wed, Oct 23, 8:17 PM
Unknown Object (File)
Oct 6 2024, 3:43 PM
Unknown Object (File)
Oct 3 2024, 4:30 AM
Unknown Object (File)
Oct 1 2024, 3:47 PM
Unknown Object (File)
Sep 12 2024, 9:18 PM
Unknown Object (File)
Aug 22 2024, 9:45 PM
Unknown Object (File)
Aug 18 2024, 11:41 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T5893: Modernize Date Picker
Commits
Restricted Diffusion Commit
rPcd82b90c154a: Modernize DatePicker
Summary

Fixes T5893. Uses more standard colors / spacing / shadows / icons.

Test Plan

pick dates

undefined (301×344 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 24768.Aug 16 2014, 9:31 PM
chad retitled this revision from to Modernize DatePicker.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T5893: Modernize Date Picker.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 16 2014, 9:31 PM
chad edited the test plan for this revision. (Show Details)Aug 16 2014, 9:31 PM
Harbormaster completed remote builds in B2257: Diff 24768.Aug 16 2014, 9:32 PM
epriestley accepted this revision.Aug 16 2014, 9:38 PM
epriestley edited edge metadata.

This feels a littttle bit floatey to me without the background fill tying the popup to the control, but I also have a hard time imagining users will ever be confused.

This revision is now accepted and ready to land.Aug 16 2014, 9:38 PM
chad closed this revision.Aug 16 2014, 9:55 PM
chad updated this revision to Diff 24769.

Closed by commit rPcd82b90c154a (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
form/
control/
5 lines
webroot/
rsrc/
css/
phui/
65 lines
js/
core/
5 lines

Diff 24769

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...
Phabricator · Built by Phacility