Page MenuHomePhabricator

Don't render a grip on tasks returned over AJAX to non-draggable UIs
ClosedPublic

Authored by epriestley on Aug 16 2014, 11:44 AM.
Tags
None
Referenced Files
F18823313: D10282.diff
Thu, Oct 23, 11:18 AM
F18755746: D10282.id24764.diff
Sun, Oct 5, 7:13 AM
F18712098: D10282.id.diff
Mon, Sep 29, 5:16 AM
F18696955: D10282.diff
Sat, Sep 27, 8:40 AM
F18495688: D10282.diff
Sep 4 2025, 4:36 PM
F18090477: D10282.id24762.diff
Aug 6 2025, 3:58 PM
F18047890: D10282.diff
Aug 3 2025, 1:13 PM
F17926018: D10282.id24764.diff
Jul 30 2025, 12:28 PM
Subscribers

Details

Summary

Fixes T5140. When you ajax-edit a task and we send back a full-size card, we currently always put a drag grip on it.

If you clicked the "edit" thing from a priority-ordered list, this is appropriate. However, if you clicked it from some other type of list, it is not.

Pass the expected grippableness through the call.

Test Plan
  • Edited a task from a reorderable (priority-ordered) view, got grip.
  • Edited a task from a nonreorderable (author-ordered) view, got no grip.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't render a grip on tasks returned over AJAX to non-draggable UIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2014, 3:02 PM
epriestley updated this revision to Diff 24764.

Closed by commit rP98a847a36c26 (authored by @epriestley).