Page MenuHomePhabricator

Don't render a grip on tasks returned over AJAX to non-draggable UIs
ClosedPublic

Authored by epriestley on Aug 16 2014, 11:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:52 PM
Unknown Object (File)
Wed, Apr 17, 5:51 AM
Unknown Object (File)
Thu, Apr 11, 8:10 AM
Unknown Object (File)
Sat, Apr 6, 9:23 PM
Unknown Object (File)
Thu, Apr 4, 9:15 AM
Unknown Object (File)
Mon, Apr 1, 8:32 PM
Unknown Object (File)
Feb 8 2024, 5:48 AM
Unknown Object (File)
Jan 29 2024, 8:51 PM
Subscribers

Details

Summary

Fixes T5140. When you ajax-edit a task and we send back a full-size card, we currently always put a drag grip on it.

If you clicked the "edit" thing from a priority-ordered list, this is appropriate. However, if you clicked it from some other type of list, it is not.

Pass the expected grippableness through the call.

Test Plan
  • Edited a task from a reorderable (priority-ordered) view, got grip.
  • Edited a task from a nonreorderable (author-ordered) view, got no grip.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't render a grip on tasks returned over AJAX to non-draggable UIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2014, 3:02 PM
epriestley updated this revision to Diff 24764.

Closed by commit rP98a847a36c26 (authored by @epriestley).