Differential D10268

DiffusionCommitQuery - move phid to id mapping
ClosedPublic
Actions

Authored by btrahan on Aug 14 2014, 7:57 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5862: Allow audits to be searched for by repository

Commits

Restricted Diffusion Commit
rPf8af89a99efc: DiffusionCommitQuery - move phid to id mapping

Summary

Ref T5862. makes the exception work better

Test Plan

issued some queries from audit ui with and without repos - they worked

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24725.Aug 14 2014, 7:57 PM

btrahan added a task: T5862: Allow audits to be searched for by repository.

btrahan retitled this revision from to DiffusionCommitQuery - move phid to id mapping.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 14 2014, 7:57 PM

epriestley accepted this revision.Aug 14 2014, 7:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 14 2014, 7:58 PM

Harbormaster completed remote builds in B2229: Diff 24725.Aug 14 2014, 7:58 PM

Closed by commit rPf8af89a99efc (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

query/

PhabricatorCommitSearchEngine.php

3 lines

diffusion/

query/

DiffusionCommitQuery.php

29 lines

Diff 24726

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php