Differential D10258

Provide a setup warning about using the default MySQL stopword file
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 8:46 PM.

Tags

None

Referenced Files

	F14822952: D10258.id.diff
	Tue, Jan 28, 10:21 AM

	F14822737: D10258.id24694.diff
	Tue, Jan 28, 9:29 AM

	Unknown Object (File)
	Mon, Jan 27, 10:27 PM

	Unknown Object (File)
	Mon, Jan 27, 10:26 PM

	Unknown Object (File)
	Mon, Jan 27, 10:26 PM

	Unknown Object (File)
	Mon, Jan 27, 8:10 AM

	Unknown Object (File)
	Sun, Jan 26, 3:20 AM

	Unknown Object (File)
	Sat, Jan 25, 12:59 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2605: Search on secure.phabricator.com doesn't find MySQL stopwords

Commits

Restricted Diffusion Commit
rPe616f166ae9f: Provide a setup warning about using the default MySQL stopword file

Summary

Fixes T2605.

Add a setup warning about the stopword file.
Provide a simpler stopword file.

Test Plan

Hit setup warning.
Resolved it according to instructions.
Added "various" to a task, then searched for it, found the task.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24694.Aug 13 2014, 8:46 PM

epriestley retitled this revision from to Provide a setup warning about using the default MySQL stopword file.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2605: Search on secure.phabricator.com doesn't find MySQL stopwords.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 8:46 PM

epriestley added inline comments.Aug 13 2014, 8:47 PM

resources/sql/stopwords.txt
2	I generated this by taking a list of the 500 most common english words from Google and going down them randomly removing things I imagined people might conceivably want to search for.

Harbormaster completed remote builds in B2214: Diff 24694.Aug 13 2014, 8:47 PM

btrahan accepted this revision.Aug 13 2014, 9:56 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 13 2014, 9:56 PM

Closed by commit rPe616f166ae9f (authored by @epriestley).

chad mentioned this in T6539: Query: Searching for tasks which contain the word "do" does not seem to work.Nov 12 2014, 7:03 PM

epriestley mentioned this in D10955: Properly create Elasticsearch index.Dec 15 2014, 12:20 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

50 lines

src/

applications/

config/

check/

PhabricatorSetupCheckMySQL.php

52 lines

search/

selector/

PhabricatorDefaultSearchEngineSelector.php

9 lines

Diff 24701

resources/sql/stopwords.txt

Loading...

src/applications/config/check/PhabricatorSetupCheckMySQL.php

Loading...

src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php

Loading...