Add "View Email" action to application transactions
ClosedPublic
Actions

Authored by btrahan on Aug 12 2014, 9:01 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5768: Add a "view raw" action to comments

Commits

Restricted Diffusion Commit
rPea3aeb49623b: Add "View Email" action to application transactions

Summary

Should help with debugging. In the web UI there is now a link to "View Email". This uses the same debugging output that ./bin/mail show-outbound uses. Fixes T5768. Code is very defensive as I think these tables may be truncated eventually?

Test Plan

viewed some emails and it worked!

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24647.Aug 12 2014, 9:01 PM

btrahan added a task: T5768: Add a "view raw" action to comments.

btrahan retitled this revision from to Add "View Email" action to application transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 12 2014, 9:01 PM

Harbormaster completed remote builds in B2183: Diff 24647.Aug 12 2014, 9:02 PM

We can't show all the debugging information: the "To" address sometimes contains a per-user secret hash which allows other users to spoof them.

Let's just show the text body, and a message like "for full details, run bin/mail show-inbound --id XYZ"?

src/view/phui/PHUITimelineEventView.php
548–550	This will issue a bunch of queries when viewing a page with a lot of comments -- let's just trust that it exists, and check when someone actually clicks through?

This revision now requires changes to proceed.Aug 12 2014, 9:06 PM