Fixes T5848.
- Disallow tracking negative time.
- Preserve note if there's an error with the time selection.
- Show start time and duration.
- Slightly better error messages.
Details
Details
- Reviewers
hach-que btrahan - Maniphest Tasks
- T5848: Phrequent allows users to track negative time
- Commits
- Restricted Diffusion Commit
rPfc814647e60a: Improve usability of Phrequent "Stop Time" dialog
Started and stopped time. Tried to select future/negative ranges.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
The "future" time thing strikes me as something people might have used - "I am going to work on this for the next two hours", etc - but I think this is better as is and will yield more accurate tracking overall.
| src/applications/phrequent/controller/PhrequentTrackController.php | ||
|---|---|---|
| 59–60 | Yeah, I think I agree with you -- and almost added at least a fuzz factor here (e.g., you can set a stop time up to 15 minutes in the future). However, it did previously stop you from future-stop-times (just not negative-stop-times) so I figured I'd leave that as-is until we get complaints. If users run into this, I think fuzz-factor ("you can stop work at 5:00 PM if it's 4:53 right now") would be 100% reasonable and "any future time you want" would be like 90% reasonable. | |