Fix dashboard list if there are no results
ClosedPublic
Actions

Authored by epriestley on Aug 10 2014, 2:02 AM.

Tags

None

Referenced Files

	F13258963: D10207.id.diff
	Sun, May 26, 2:30 PM

	F13248793: D10207.id24565.diff
	Fri, May 24, 4:07 AM

	F13248792: D10207.id24564.diff
	Fri, May 24, 4:07 AM

	F13230904: D10207.diff
	Mon, May 20, 11:24 PM

	F13227422: D10207.id24564.diff
	Mon, May 20, 3:18 AM

	F13185863: D10207.diff
	Sat, May 11, 3:16 AM

	Unknown Object (File)
	Tue, May 7, 5:49 AM

	Unknown Object (File)
	Fri, May 3, 3:32 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPc0919be0ecbd: Fix dashboard list if there are no results

Summary

We'll fire a bad query if there are no dashboards in the result list, see:

http://pastie.org/private/j0f8tzbdahwragxjsk8qxq

Test Plan

Viewed result list with no dashboards.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24564.Aug 10 2014, 2:02 AM

epriestley retitled this revision from to Fix dashboard list if there are no results.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 10 2014, 2:02 AM

chad accepted this revision.Aug 10 2014, 2:03 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 10 2014, 2:03 AM

Harbormaster completed remote builds in B2137: Diff 24564.Aug 10 2014, 2:03 AM

Closed by commit rPc0919be0ecbd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

query/

PhabricatorDashboardSearchEngine.php

19 lines

Diff 24565

View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Fix dashboard list if there are no resultsClosedPublicActions