Allow the workboard backlog column to be reordered
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 3:39 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5677: Support moving the "backlog" column

Commits

Summary

Fixes T5677.

Instead of using sequence == 0 to mean "this is the backlog column", flag the column explicitly.
Migrate existing sequence 0 columns to have the flag.
Add the flag when initializing or copying a board.
Remove special backlog logic when reordering columns.

Test Plan

Migrated columns, viewed some boards, they looked identical.
Reordered the backlog column a bunch of times (first, last, middle, dragged other stuff around).
Added tasks to a project, saw them show up in the reordered backlog.
Initialized a new board and saw a backlog column show up.
Copied an existing board and saw the backlog column come over.
Tried to hide a backlog column.

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

epriestley retitled this revision from to Allow the workboard backlog column to be reordered.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Awesome!

src/applications/project/controller/PhabricatorProjectBoardViewController.php
169–180	I think $defaut_phid needs to be updated to? This code reads to me that the "0th position column gets all the tasks by default". That said, your test plan covers the case I'd expect to fail - having tasks show up in a "default" column that is not in position 0. Maybe we're explicitly writing relationships for the "default" case now and this code can be delated? (i.e. on line 174 the isset() always returns true in modern times?)

This revision is now accepted and ready to land.Aug 8 2014, 10:49 PM

Closed by commit rP24a6eeb8d8a5 (authored by @epriestley).

src/applications/project/controller/PhabricatorProjectBoardViewController.php
169–180	Oops, jumped the gun on this. Nice catch! Your second paragraph is right (we should never be able to miss on `$positions` now, or if we can it's surprising / a bug) -- I'll clean this up.