Paths

Table of Contentst

Differential D10185

T5409, allow bin/remove to permanently destroy credential and everything associated with it
ClosedPublic
Actions

Authored by lpriestley on Aug 7 2014, 11:09 PM.

Tags

None

Referenced Files

	F18803680: D10185.id24501.diff
	Oct 18 2025, 2:45 AM

	F18799054: D10185.diff
	Oct 17 2025, 10:59 AM

	F18764040: D10185.id24502.diff
	Oct 7 2025, 3:51 AM

	F18677943: D10185.diff
	Sep 25 2025, 9:42 PM

	F18628471: D10185.id.diff
	Sep 16 2025, 6:23 AM

	F18614736: D10185.diff
	Sep 14 2025, 1:10 PM

	F18601321: D10185.id.diff
	Sep 13 2025, 12:09 PM

	F18495636: D10185.diff
	Sep 4 2025, 4:34 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5409: Allow /bin/remove to destroy permanently a passphrase record

Commits

Restricted Diffusion Commit
rPc6998207ab00: T5409, allow bin/remove to permanently destroy credential and everything…

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Fixes T5409, bin/remove permanently destroys credential

Test Plan

Add a passphrase, run bin/remove destroy K123 --trace, verify credential no longer exists

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 24500.Aug 7 2014, 11:09 PM

lpriestley retitled this revision from to T5409, allow bin/remove to permanently destroy credential and everything associated with it.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T5409: Allow /bin/remove to destroy permanently a passphrase record.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 7 2014, 11:09 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2096: Diff 24500.Aug 7 2014, 11:10 PM

One minor issue inline.
you betta sign that CLA

src/applications/passphrase/storage/PassphraseCredential.php
95	This isn't quiet correct -- it should be `$this->secretID()`. Currently this is destroying the Secret that happens to have the same ID as the Credential, but they aren't guaranteed to be related.

This revision now requires changes to proceed.Aug 7 2014, 11:14 PM

Adding requested changes

Harbormaster completed remote builds in B2097: Diff 24501.Aug 7 2014, 11:21 PM

This revision is now accepted and ready to land.Aug 7 2014, 11:33 PM

Closed by commit rPc6998207ab00 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

storage/

PassphraseCredential.php

18 lines

system/

interface/

PhabricatorDestructibleInterface.php

2 lines

Diff 24502

src/applications/passphrase/storage/PassphraseCredential.php

Loading...

src/applications/system/interface/PhabricatorDestructibleInterface.php

Loading...