Page MenuHomePhabricator

When selecting implicit column positions, actually create them
ClosedPublic

Authored by epriestley on Aug 7 2014, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 10:59 AM
Unknown Object (File)
Thu, Dec 12, 3:01 AM
Unknown Object (File)
Sun, Dec 8, 10:52 PM
Unknown Object (File)
Sun, Dec 8, 2:49 PM
Unknown Object (File)
Wed, Dec 4, 8:49 AM
Unknown Object (File)
Tue, Dec 3, 8:28 AM
Unknown Object (File)
Sat, Nov 30, 9:47 AM
Unknown Object (File)
Tue, Nov 26, 9:45 PM
Subscribers

Details

Summary

Ref T4807. This is an alternative to D10179. The problem these diffs solve is that I want to be able to reorder a column's positions without having to load the actual objects, but that's difficutl because two positions may have the same sequence number (and I think it's good that we allow that, since it makes a bunch of other stuff way easier).

Instead of using the object ID (e.g., the task ID) to reorder positions with the same sequence, use the position itself. This is a little easier, is less ambiguous if columns eventually have several types of objects, and produces a better behavior when old objects are freshly added to a board. For example, if you tag T300 with #project, this new rule will push it to the top of "Backlog" while the old rule might have buried it deep. I think this behavior is desirable and more "natural".

When creating a group of new rows, we do order the batch by ID, so a group of freshly-tagged objects float to the top togehter in ID order. This seems like the most natural rule, too.

Test Plan
  • Loaded some boards with implicit objects on them (freshly tagged tasks) and saw rows create.
  • Verified new rows created in the right order.
  • Dragged some tasks around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to When selecting implicit column positions, actually create them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Yah, this seems better. :)

This revision is now accepted and ready to land.Aug 7 2014, 8:03 PM
epriestley updated this revision to Diff 24514.

Closed by commit rP043e0db8d36b (authored by @epriestley).