Add UI for alternate board ordering rules
ClosedPublic
Actions

Authored by epriestley on Aug 7 2014, 6:04 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything"

Commits

Restricted Diffusion Commit
rPfdf6b56261db: Add UI for alternate board ordering rules

Summary

Ref T4807. This doesn't actually do anything yet, but adds a dropdown menu for choosing an ordering and gets all the UI working correctly.

This also fixes a bug where column hidden state wouldn't persist across filter changes.

(I won't land this until it does something, but the next diff will probably be a mess so this seemed like a clean place to sever things.)

Test Plan

Screen_Shot_2014-08-07_at_10.55.04_AM.png (1×1 px, 178 KB)

Altered sort ordering.
Altered hidden state and filters, verified all states persisted correctly.
Added phlog() to edit/create and move controllers and verified they receive sort information.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24484.Aug 7 2014, 6:04 PM

epriestley retitled this revision from to Add UI for alternate board ordering rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".

Herald added a subscriber: epriestley. · View Herald TranscriptAug 7 2014, 6:04 PM

Harbormaster completed remote builds in B2086: Diff 24484.Aug 7 2014, 6:05 PM

Is this sticky per board or globally?

It only persists in the current browser window, like the filtering.

chad accepted this revision.Aug 7 2014, 7:41 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Aug 7 2014, 7:41 PM

(I think making these sticky in some way would be reasonable, but would like to stabilize the functionality first. My gut is per-user-per-board? But this feels like it might be a can of worms and users haven't specifically asked after it yet.)

Yeah I've thought about this all morning and no clear answer. We can ship and get feedback from @swisspol, etc from actual use.

I think you have the right defaults though.

Yeah, my guess is that "Natural" will become 95% of use after it works.

(I think alternate sort orders are still useful, which is why I'm retaining "priority", and I'd like to pursue the headers-in-the-column design at some point to make priority more useful/explicit, but expect that to land somewhere over the horizon on the roadmap if Natural proves dominant.)