this data is a little weird since its user-entered and we need to put it in a web page un-escaped for the font to load correctly. Ergo, we use a regex to make the input safe / sane, and said regex needs to support a '.'. Fixes T5810.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5810: Monospaced Font field in Display Preferences remove dots
- Commits
- Restricted Diffusion Commit
rP20a65b21eba9: Settings - upgrade monospace font regexp to support '.'
added Fixedsys Excelsior 3.01 to my system and was able to set my preference and get the new font
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Should we also consider to add also an underscore? I've already met that in some _webfont in the past, but only in test fonts.
I see this is frowned upon at http://typophile.com/node/52771 but it doesn't allow to quit the protected string and write arbitray CSS.
Comment Actions
For reference, D7274 was another effort in this vein that reached further and which I was able to break out of. This seems fine, though.