Page MenuHomePhabricator

Fix tabs losing scroll position
ClosedPublic

Authored by btrahan on Aug 1 2014, 7:08 PM.
Tags
None
Referenced Files
F15380318: D10111.id24316.diff
Fri, Mar 14, 2:31 AM
Unknown Object (File)
Jan 31 2025, 11:36 PM
Unknown Object (File)
Jan 24 2025, 9:58 PM
Unknown Object (File)
Jan 24 2025, 3:27 AM
Unknown Object (File)
Jan 24 2025, 3:27 AM
Unknown Object (File)
Jan 17 2025, 6:55 PM
Unknown Object (File)
Jan 15 2025, 3:47 AM
Unknown Object (File)
Jan 13 2025, 2:19 AM
Subscribers

Details

Summary

we were missing an e.kill(). Fixes T5754.

Test Plan

looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Fix tabs losing scroll position.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:18 PM
btrahan updated this revision to Diff 24317.

Closed by commit rPd18ba3f0045c (authored by @btrahan).