Fix tabs losing scroll position
ClosedPublic
Actions

Authored by btrahan on Aug 1 2014, 7:08 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5754: Changing tabs (for property lists) does not maintain current vertical position in Chrome

Commits

Restricted Diffusion Commit
rPd18ba3f0045c: Fix tabs losing scroll position

Summary

we were missing an e.kill(). Fixes T5754.

Test Plan

looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved!

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24316.Aug 1 2014, 7:08 PM

btrahan added a task: T5754: Changing tabs (for property lists) does not maintain current vertical position in Chrome.

btrahan retitled this revision from to Fix tabs losing scroll position.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2014, 7:08 PM

Harbormaster completed remote builds in B1987: Diff 24316.Aug 1 2014, 7:10 PM

epriestley accepted this revision.Aug 1 2014, 7:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2014, 7:18 PM

Closed by commit rPd18ba3f0045c (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

phui/

behavior-phui-object-box-tabs.js

1 line

Diff 24317

View Options

resources/celerity/map.php