Page MenuHomePhabricator
Differential D10097

Allow pastes to be edited from conduit call.
Needs RevisionPublic
Actions

Authored by maroux on Jul 31 2014, 6:15 PM.
Tags
None
Referenced Files
F14005030: D10097.diff
Sun, Oct 27, 6:32 AM
F13994045: D10097.id.diff
Wed, Oct 23, 3:20 AM
F13961558: D10097.diff
Tue, Oct 15, 5:30 AM
Unknown Object (File)
Oct 6 2024, 6:23 AM
Unknown Object (File)
Oct 1 2024, 7:59 AM
Unknown Object (File)
Sep 24 2024, 2:44 AM
Unknown Object (File)
Sep 18 2024, 3:15 PM
Unknown Object (File)
Sep 12 2024, 6:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Allow pastes to be edited from conduit call.

Test Plan

Test using arcanist paste --edit command

Diff Detail

Repository
rP Phabricator
Branch
paste-edit-conduit-method
Lint
Lint Errors
SeverityLocationCodeMessage
Error/vagrant/libphutil/src/future/http/HTTPSFuture.php:533PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 1967
Build 1968: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

maroux updated this revision to Diff 24281.Jul 31 2014, 6:15 PM
maroux retitled this revision from to Allow pastes to be edited from conduit call..
maroux updated this object.
maroux edited the test plan for this revision. (Show Details)
maroux added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 6:15 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1967: Diff 24281.Jul 31 2014, 6:16 PM
epriestley edited edge metadata.Jul 31 2014, 6:32 PM

Can you walk me through your use case? Why do you want to edit pastes from the CLI?

maroux added a comment.Jul 31 2014, 6:41 PM

@epriestley Well, my main use case is I want to share some code/files internally and Paste is the perfect application for this. The problem is Pastes can't be edited from scripts.

Besides, since Pastes are supposed to be editable from the UI, I figured we should make conduit API as powerful.

Btw, this is my first diff in phabricator. Please let me know if I'm missing something in the process/code convention etc. Thanks!

maroux added a comment.Jul 31 2014, 6:50 PM

Fyi, the diff for arcanist is here: D10099: Adding support for editing paste in `arc paste` workflow.

epriestley requested changes to this revision.May 14 2015, 2:55 PM
epriestley edited edge metadata.

This should wait for T5873 and be rebuilt on top of it.

This revision now requires changes to proceed.May 14 2015, 2:55 PM
epriestley mentioned this in D10099: Adding support for editing paste in `arc paste` workflow.Nov 2 2015, 4:51 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
paste/
conduit/
102 lines

Diff 24281

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/paste/conduit/PasteEditConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility