Differential D10096

Move build status to the bottom of the property list
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 8:49 AM.

Tags

None

Referenced Files

	F14407133: D10096.diff
	Tue, Dec 24, 1:58 AM

	Unknown Object (File)
	Mon, Nov 25, 3:47 PM

	Unknown Object (File)
	Nov 21 2024, 10:46 AM

	Unknown Object (File)
	Nov 16 2024, 11:19 PM

	Unknown Object (File)
	Nov 16 2024, 10:20 PM

	Unknown Object (File)
	Nov 8 2024, 2:19 PM

	Unknown Object (File)
	Oct 24 2024, 3:37 PM

	Unknown Object (File)
	Oct 19 2024, 10:59 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP8b5192ed713e: Move build status to the bottom of the property list

Summary

This moves the status property of the build to the bottom of the property list so that it matches the build targets.

Test Plan

Viewed a build, saw the status in the right position.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24278.Jul 31 2014, 8:49 AM

hach-que retitled this revision from to Move build status to the bottom of the property list.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 8:49 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1964: Diff 24278.Jul 31 2014, 8:50 AM

This seems important, maybe we should move the other one up instead?

This revision is now accepted and ready to land.Jul 31 2014, 7:52 PM

In the context of D10095, it makes more sense to have it at the bottom, otherwise it visually merges with the header colour. Keeping it further away from the header allows you to see it distinctly (and thus see the actual textual status and icon easier).

Closed by commit rP8b5192ed713e (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildViewController.php

8 lines

Diff 24296

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...