Page MenuHomePhabricator
Differential D10043

Fix crazystairs with non-stairlike reverse-indented lists
ClosedPublic
Actions

Authored by epriestley on Jul 24 2014, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:10 AM
Unknown Object (File)
Fri, May 3, 3:19 AM
Unknown Object (File)
Mon, Apr 29, 2:46 PM
Unknown Object (File)
Wed, Apr 24, 10:46 PM
Unknown Object (File)
Tue, Apr 16, 12:05 AM
Unknown Object (File)
Thu, Apr 11, 7:40 AM
Unknown Object (File)
Tue, Apr 9, 7:00 AM
Unknown Object (File)
Mar 31 2024, 10:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
asherkin
btrahan
chad
Maniphest Tasks
T5102: Markdown syntax of README.md file present in a repository is not well rendered
Commits
rPHU2603d59f43b0: Fix crazystairs with non-stairlike reverse-indented lists
Summary

Ref T5102. This loop is supposed to select the first item at the minimum depth, but uses < rather than <= so it selects the last item instead.

Test Plan

Added and ran unit tests. Viewed stairs in preview, they worked correctly.

Screen_Shot_2014-07-24_at_4.17.29_PM.png (543×418 px, 24 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24139.Jul 24 2014, 11:17 PM
epriestley retitled this revision from to Fix crazystairs with non-stairlike reverse-indented lists.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: asherkin, chad, btrahan.
epriestley added a task: T5102: Markdown syntax of README.md file present in a repository is not well rendered.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2014, 11:17 PM
Harbormaster completed remote builds in B1879: Diff 24139.Jul 24 2014, 11:18 PM
chad accepted this revision.Jul 25 2014, 4:05 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2014, 4:05 AM
epriestley closed this revision.Jul 25 2014, 4:58 AM
epriestley updated this revision to Diff 24164.

Closed by commit rPHU2603d59f43b0 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
16 lines
remarkup/
blockrule/
2 lines

Diff 24164

View Options

src/markup/engine/__tests__/remarkup/list-crazystairs.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

Loading...
Phabricator · Built by Phacility