support for prepending paths to system PATH environment variable
Needs RevisionPublic
Actions

Authored by • markr on Jul 23 2014, 5:49 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Added support for prepending paths to system PATH environment variable using "prepend-paths" configuration option. Useful when using non-system packages, for example macports in OSX.

Test Plan

Use non-system git commands for ssh access while set and sudoers are using this path. Should fail when path is not set and succed when set. Make sure UI represents changes correctly. Make sure that option is a command line option only (should not be settable by web interface).

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 1864
Build 1865: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

• markr updated this revision to Diff 24110.Jul 23 2014, 5:49 PM

• markr retitled this revision from to support for prepending paths to system PATH environment variable.

• markr updated this object.

• markr edited the test plan for this revision. (Show Details)

• markr added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 23 2014, 5:49 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1864: Diff 24110.Jul 23 2014, 5:50 PM

This is already complicated and I don't want to make it more complicated to support an unusual edge case. We'll prepend phabricator/support/bin/ to PATH automatically and you can symlink things in there if you have some particularly unusual setup.

This revision now requires changes to proceed.Jul 23 2014, 5:55 PM

• hatv added a subscriber: • hatv.Oct 15 2014, 10:23 AM